add explicit type #3816
Merged
add explicit type #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuwei-k
force-pushed
the
explicit-type
branch
from
764f566
to
1a07945
Compare
armanbilge
reviewed
Sep 10, 2023
| @@ -1223,7 +1223,7 @@ private[effect] trait ResourceHOInstances0 extends ResourceHOInstances1 { | |||
| implicit def catsEffectAsyncForResource[F[_]](implicit F0: Async[F]): Async[Resource[F, *]] = | |||
| new ResourceAsync[F] { | |||
| def F = F0 | |||
| override def applicative = this | |||
| override def applicative: ResourceAsync[F] = this | |||
There was a problem hiding this comment.
I'm not sure if it matters, but can this be:
Suggested change
| override def applicative: ResourceAsync[F] = this | |
| override def applicative: Async[Resource[F, *]] = this |
There was a problem hiding this comment.
typelevel/cats-effect/kernel/shared/src/main/scala/cats/effect/kernel/Resource.scala:1226:20: incompatible type in overriding
[error] override def applicative: cats.effect.kernel.ResourceAsync[F] (defined in class ResourceAsync);
[error] found : cats.effect.kernel.Async[[β$26$]cats.effect.kernel.Resource[F,β$26$]]
[error] required: cats.effect.kernel.ResourceAsync[F]
[error] override def applicative: Async[Resource[F, *]] = this
[error] ^
[error] one error found
[error] (Compile / compileIncremental) Compilation failed
🤔
There was a problem hiding this comment.
Thanks. I was surprised some of the other ones could use the more general type. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare Scala 2.13.12
-Xsource:3as fatal warnings, not errors;-Xmigrationturns off erroring scala/scala#10439